Re: [PATCH 02/25] x86/cpufeatures: Add SGX1 and SGX2 sub-features
From: Kai Huang <hidden>
Date: 2021-03-01 11:29:37
Also in:
lkml
On Mon, 2021-03-01 at 11:53 +0100, Borislav Petkov wrote:
On Mon, Mar 01, 2021 at 11:40:02PM +1300, Kai Huang wrote:quoted
SGX2 means "Enclave Dynamic Memory Management", which supports dynamically adding/removing EPC pages, plus changing page permission, after enclave is initialized. So it allows enclave author to write enclave in more flexible way, and also utilize EPC resource more efficiently.So how is the enclave author going to use "sgx2" in /proc/cpuinfo? Query it to know whether it can start adding/removing EPC pages or is this going to be used by scripts?
I think some script can utilize /proc/cpuinfo. For instance, admin can have automation tool/script to deploy enclave (with sgx2) apps, and that script can check whether platform supports sgx2 or not, before it can deploy those enclave apps. Or enclave author may just want to check /proc/cpuinfo to know whether the machine can be used for testing sgx2 enclave or not. However this is just my 2 cents.
quoted
Yes I can add "why" into commit message, but isn't the comment after X86_FEATURE_SGX2 enough? I think people who are interested in SGX will know what SGX2 is and why SGX2 is useful.The point is, the commit message should say how this flag in /proc/cpuinfo is going to be used - not what people interested in sgx might and might not know. /proc/cpuinfo is user-visible ABI - you can't add stuff to it just because.
Thanks for the explaining. Will do.