[PATCH] reformat_with_checkpatch: Add automation to checkpatch
From: gregkh@linuxfoundation.org (Greg KH)
Date: 2014-07-12 02:00:53
Also in:
kernel-janitors, lkml
On Fri, Jul 11, 2014 at 07:01:14PM -0700, Greg KH wrote:
On Fri, Jul 11, 2014 at 06:46:52PM -0700, Joe Perches wrote:quoted
On Fri, 2014-07-11 at 18:39 -0700, Greg KH wrote:quoted
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:quoted
A simple script to run checkpatch --fix for various types of of cleanups.]quoted
drivers/staging/lustre/include/linux/lnet/api.h has no obvious style problems and is ready for submission. file: <drivers/staging/lustre/include/linux/lnet/api.h> description: <update c90 comment style> types:<c99_comments> Useless use of greediness modifier '+' in regex; marked by <-- HERE in m/(^\+.*) {8,8}+ <-- HERE \t/@./scripts/checkpatch.pl line 2217.[]quoted
drivers/staging/lustre/include/linux/lnet/api.h has no obvious style problems and is ready for submission.[]quoted
Is that expected?No, I haven't seen that. Can you tell me what git tree you're working on?My staging-next branch of staging.git on git.kernel.orgquoted
Also, can you use the scripts/checkpatch from -next tag next-20140711that will take a bit to checkout, I'll do that afterward.quoted
My system has: $ perl --version This is perl 5, version 18, subversion 2 (v5.18.2) built for i686-linux-gnu-thread-multi-64int (with 41 registered patches, see perl -V for more detail)I think this started showing up for me for perl 5.20. Let me go checkout linux-next and see if that fixes anything or not...
Ok, with linux-next I get the same thing:
~/linux/tmp/linux-next $ ./scripts/checkpatch.pl -f --strict drivers/staging/lustre/include/linux/lnet/api.h --types=c99_comments
Useless use of greediness modifier '+' in regex; marked by <-- HERE in m/(^\+.*) {8,8}+ <-- HERE \t/@./scripts/checkpatch.pl line 2358.
total: 0 errors, 0 warnings, 0 checks, 220 lines checked
NOTE: Used message types: C99_COMMENTS
drivers/staging/lustre/include/linux/lnet/api.h has no obvious style problems and is ready for submission.