On 11-Aug-12, at 10:42 PM, Michael Cree wrote:

On 12/08/12 14:10, Fengguang Wu wrote:

quoted

On Sun, Aug 12, 2012 at 01:33:09PM +1200, Michael Cree wrote:

quoted

On 03/08/12 03:02, Fengguang Wu wrote:

quoted

On Thu, Jul 26, 2012 at 10:06:41AM -0700, Tony Luck wrote:

quoted

On Tue, Jul 24, 2012 at 10:10 PM, James Bottomley
[off-list ref] wrote:

quoted

quoted

Here is the line in sock.i:

struct static_key memalloc_socks = ((struct static_key)  
{ .enabled =
((atomic_t) { (0) }) });

The above line contains two compound literals.  It also uses a  
designated
initializer to initialize the field enabled.  A compound  
literal is not a
constant expression.

Seeing the same thing on ia64 building next-20120726.  Same fix  
works
for me ... so I'll steal this whole changelog and attributes.

I got the same error for alpha, the same fix applies.

Just trying this patch on Alpha against v3.6-rc1 and it leads to new
compilation errors, namely:

init/init_task.c:12: error: braced-group within expression allowed  
only
inside a function
init/init_task.c:13: error: braced-group within expression allowed  
only
inside a function
init/init_task.c:16: error: braced-group within expression allowed  
only
inside a function
init/init_task.c:16: error: braced-group within expression allowed  
only
inside a function
make[1]: *** [init/init_task.o] Error 1

Sorry! This will actually compile:

-#define ATOMIC_INIT(i)         ( { (i) } )
+#define ATOMIC_INIT(i)         { (i) }

Thanks, it now compiles correctly.  I'm currently collecting Alpha
patches to send on to Linus so will include this one.

A similar change applied to 3.5.1 stable compiles successfully
on parisc.

Regards,
Dave
--
John David Anglin	dave.anglin@bell.net