[PATCH] [ALPHA] Redefine ATOMIC_INIT and ATOMIC64_INIT to drop the casts
From: Fengguang Wu <hidden>
Date: 2012-08-12 02:14:30
Also in:
linux-alpha, lkml
From: Mel Gorman <mgorman@suse.de> The following build error occurred during an alpha build: net/core/sock.c:274:36: error: initializer element is not constant Dave Anglin says:
Here is the line in sock.i:
struct static_key memalloc_socks = ((struct static_key) { .enabled > ((atomic_t) { (0) }) });The above line contains two compound literals. It also uses a designated initializer to initialize the field enabled. A compound literal is not a constant expression. The location of the above statement isn't fully clear, but if a compound literal occurs outside the body of a function, the initializer list must consist of constant expressions. Cc: <redacted> Signed-off-by: Mel Gorman <mgorman@suse.de> Signed-off-by: Fengguang Wu <redacted> --- arch/alpha/include/asm/atomic.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
--- linux.orig/arch/alpha/include/asm/atomic.h 2012-08-12 10:12:36.667523339 +0800
+++ linux/arch/alpha/include/asm/atomic.h 2012-08-12 10:12:37.659523362 +0800@@ -14,8 +14,8 @@ */ -#define ATOMIC_INIT(i) ( (atomic_t) { (i) } ) -#define ATOMIC64_INIT(i) ( (atomic64_t) { (i) } ) +#define ATOMIC_INIT(i) { (i) } +#define ATOMIC64_INIT(i) { (i) } #define atomic_read(v) (*(volatile int *)&(v)->counter) #define atomic64_read(v) (*(volatile long *)&(v)->counter)