On Mon, Jul 12, 2021 at 5:37 AM Dmitry Kadashev [off-list ref] wrote:

Moving the main logic to a helper function makes the whole thing much
easier to follow.

Ok, this has the same thing as the previous patches had.

I see why the old code tried to avoid the repeat of some tests, but
honestly, that "retry_estale()" might as well be marked "unlikely()",
and we might as well do the test again if it triggers.

That said, in this case we actually end up doing other things too in
"do_linkat()", so I guess it could go either way.

              Linus