Re: [PATCH v2] remote.c: defer remote.<name>.followRemoteHEAD validation

From
Junio C Hamano <hidden>
Date
2026-11-06 16:15:13
Reply to
Matt Hunter, 2026-11-06
"Matt Hunter" [off-list ref] writes:
On Thu Nov 5, 2026 at 11:03 PM EST, Junio C Hamano wrote:
quoted
Hmph, interesting.  Can you rewrite Colin's patch using this, and
then merge the result into 'seen' (after reverting Colin's topic
ch/remote-defer-follow-remote-head-validation from 'seen' first) to
see how badly it crashes with other topics in flight?
I still have the commit sitting around.  I tried this and a replay of
the current topic to compare -- the conflict is the same in both
cases.  eg: Nothing else in flight is touching the
get_follow_remote_head() function.
Thanks for investigating.  

Your approach of passing more context into get_follow_remote_head()
and have _it_ do the (lazy) conversion from string to value makes it
much easier for callers to make calls from multiple branches to the
function, because the need to "set-up" to make the call disappears.

Very cleanly done.

Colin, what's your preference?  Can we move this topic past the
finish line?

Thanks.
Thread (19 messages) 19 messages, 3 authors, last reply 51m ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help