Re: [PATCH v2] remote.c: defer remote.<name>.followRemoteHEAD validation

From
Junio C Hamano <hidden>
Date
2026-10-30 15:12:19
Reply to
Matt Hunter, 2026-10-30
"Matt Hunter" [off-list ref] writes:
On Wed Oct 28, 2026 at 10:26 AM EDT, Junio C Hamano wrote:
quoted
quoted
quoted
This part of the code becomes overly deeply indented, and more
importantly, the outer conditional around here has been reworked by
another topic and the code that learns follow_remote_head will have
to be reused elsewhere, which would lead to a nasty merge conflict.
...
I wonder if it makes sense to incorporate such a new helper function
into the existing 'get_follow_remote_head()', since it would be the only
place using it.
I am not sure what being the only place has to do with avoiding to
split a helper function out to clarify the main logic flow, though.
And simultaneously, another topic wants to have this piece of logic
twice.
Thread (19 messages) 19 messages, 3 authors, last reply 51m ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help