[PATCH v2 1/7] path: drop useless `safe_create_leading_directories_1()`
flat view
COOLING14d
From: Patrick Steinhardt <hidden>
Date: 2026-09-28 09:51:50
Subsystem:
the rest · Maintainer:
Linus Torvalds
The function `safe_create_leading_directories_1()` is being called by both `safe_create_leading_directories()` and its `_no_share()` variant. It is ultimately the exact same as the former of these functions though and is thus quite useless. Drop the function and inline it into its callsites directly. Signed-off-by: Patrick Steinhardt <redacted> --- path.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/path.c b/path.c
index c3a709a928..69b06c9464 100644
--- a/path.c
+++ b/path.c@@ -829,8 +829,8 @@ int safe_create_dir_in_gitdir(struct repository *repo, const char *path) return adjust_shared_perm(repo, path); } -static enum scld_error safe_create_leading_directories_1(struct repository *repo, - char *path) +enum scld_error safe_create_leading_directories(struct repository *repo, + char *path) { char *next_component = path + offset_1st_component(path); enum scld_error ret = SCLD_OK;
@@ -884,15 +884,9 @@ static enum scld_error safe_create_leading_directories_1(struct repository *repo return ret; } -enum scld_error safe_create_leading_directories(struct repository *repo, - char *path) -{ - return safe_create_leading_directories_1(repo, path); -} - enum scld_error safe_create_leading_directories_no_share(char *path) { - return safe_create_leading_directories_1(NULL, path); + return safe_create_leading_directories(NULL, path); } enum scld_error safe_create_leading_directories_const(struct repository *repo,
--
2.56.0.rc2.329.gd58861e689.dirty