Re: [PATCH 3/4] ci(gitlab,windows): fix Rust setup for GitLab's MinGW build
flat view
From: Patrick Steinhardt <hidden>
Date: 2026-09-24 11:22:05
On Sat, Sep 19, 2026 at 12:12:12PM +0000, Johannes Schindelin via GitGitGadget wrote:
quoted hunk ↗ jump to hunk
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index cd6fd4a504..3f24835500 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml@@ -133,8 +133,11 @@ build:mingw64: before_script: - *windows_before_script - ./ci/install-sdk.ps1 -directory "git-sdk" + - ./ci/install-dependencies.ps1 -Mingw
I wonder whether it would now make sense to also hoist "install-sdk.ps1" into "install-dependencies.ps1" now.
quoted hunk ↗ jump to hunk
script: - - git-sdk/usr/bin/bash.exe -l -c 'ci/make-test-artifacts.sh artifacts' + # The minimal SDK's profile resets PATH. + - git-sdk/usr/bin/bash.exe -l -c + 'PATH=$PATH:/c/Rust/bin ci/make-test-artifacts.sh artifacts'
Are we sure that PATH cannot ever contain spaces or should we rather quote here? Patrick