Thread (27 messages) 27 messages, 5 authors, 11d ago

Re: [PATCH 0/4] gitlab-ci: fix the cargo invocation in the Windows job

flat view

From: Karthik Nayak <hidden>
Date: 2026-09-23 12:43:44

Johannes Schindelin [off-list ref] writes:
Hi Karthik,

On Mon, 21 Sep 2026, Karthik Nayak wrote:
quoted
Johannes Schindelin [off-list ref] writes:
quoted
On Sun, 20 Sep 2026, Karthik Nayak wrote:
quoted
"Johannes Schindelin via GitGitGadget" [off-list ref] writes:
quoted
In https://lore.kernel.org/git/xmqq8q4zosri.fsf@gitster.g/ (local), Junio mentioned
that the GitLab CI seems broken since I enabled Rust in the Windows-based CI
jobs. This patch series should fix it (lightly tested, but I don't have a
whole lot of build minutes on GitLab).
I've created an MR [1] on our team repo for testing, I'll try to update
with newer versions (if any). The pipeline for this version is here [2].

[1]: https://gitlab.com/gitlab-org/git/-/merge_requests/671
[2]: https://gitlab.com/gitlab-org/git/-/pipelines/2863888081
Thank you!

It looks as if the `build:mingw64` job succeeded, as planned (although it
should now probably say `build:ucrt64`?).

The `build:msvc-meson` job seems to have timed out trying to do something
with credentials, though...
Re-ran the job and it seems to now run as expected.
Seems that now some `test:msvc-meson` jobs failed. I had a closer look:
the failures happened during the cleanup phase. Apparently there is a
problematic change in the Runner image:

All failing jobs used Runner 19.4.0~pre.2085.g4d3dddee. Its cleanup code
(https://gitlab.com/gitlab-org/gitlab-runner/-/blob/4d3dddee/shells/abstract.go#L2081)
calls `writeClearGitCredentials()`, which runs `git credential reject`:
https://gitlab.com/gitlab-org/gitlab-runner/-/blob/4d3dddee/shells/abstract.go#L758

However, this `git credential reject` then calls _Git Credential Manager_,
which assumes that it is running interactively. And that there is anything
to reject. And therefore it waits for the user to react to the open
dialog, but there is no user, so it times out after two hours.

The successfully-retried build
(https://gitlab.com/gitlab-org/git/-/jobs/16625727899) and the passing
test slice 3 (https://gitlab.com/gitlab-org/git/-/jobs/16604448474) used
Runner **18.8.0**, whose cleanup code
(https://gitlab.com/gitlab-org/gitlab-runner/-/blob/v18.8.0/shells/abstract.go#L1699)
lacks that credential-clearing call.

Might be worth pointing that out to your colleagues who are in charge of
that Runner image?
I have no idea about this, but have forwarded the message to the
appropriate team. Hopefully we see some resolution. Thanks for the
debugging!

Karthik
Ciao,
Johannes

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help