Thread (67 messages) 67 messages, 4 authors, 12d ago

Re: [PATCH v3 00/13] Fix inconsistent ref storage format terminology

From: Kaartic Sivaraam <hidden>
Date: 2026-09-14 15:08:26

On 9/9/26 16:42, Patrick Steinhardt wrote:
Changes in v3:
   - Add breadcrumbs for the old names to our documentation.
   - Use `OPT_ALIAS()` instead of manually aliasing the options.
   - Fix a comment in one of our tests that still referred to the v1
     "--ref-storage=" option.
   - Print the correct environment variables in error messages.
   - Also rename GIT_TEST_DEFAULT_REF_FORMAT.
   - Don't adapt "ref-storage-format.adoc", as that documentation is also
     shared with commands that don't support URIs yet.
   - Link to v2: https://patch.msgid.link/20260907-b4-pks-unify-ref-storage-format-v2-0-6733c90ca5b0@pks.im

This version does look good to me too. I just had one though while going 
through the patches. We appear to be rewritten the tests using only the 
newer variant of the arguments / environment variables. I wonder if we 
might also need a test or two to ensure the deprecated variants work as 
expected too.

-- 
Sivaraam
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help