Re: [PATCH v2 02/11] builtin/clone: rename "--ref-format=" to "--ref-storage-format="
From: Kaartic Sivaraam <hidden>
Date: 2026-09-08 09:21:41
On 9/7/26 16:48, Patrick Steinhardt wrote:
quoted hunk ↗ jump to hunk
diff --git a/builtin/clone.c b/builtin/clone.c index 5b25cca510..511fff9562 100644 --- a/builtin/clone.c +++ b/builtin/clone.c@@ -901,7 +901,7 @@ int cmd_clone(int argc, char *option_origin = NULL; struct string_list option_not = STRING_LIST_INIT_NODUP; const char *real_git_dir = NULL; - const char *ref_format = NULL; + const char *ref_storage_format_str = NULL; const char *option_upload_pack = "git-upload-pack"; int option_progress = -1; int option_sparse_checkout = 0;@@ -981,8 +981,10 @@ int cmd_clone(int argc, N_("any cloned submodules will be shallow")), OPT_STRING(0, "separate-git-dir", &real_git_dir, N_("gitdir"), N_("separate git dir from working tree")), - OPT_STRING(0, "ref-format", &ref_format, N_("format"), - N_("specify the reference format to use")), + OPT_STRING(0, "ref-storage-format", &ref_storage_format_str, N_("format"), + N_("specify the reference storage format to use")), + OPT_STRING_F(0, "ref-format", &ref_storage_format_str, N_("format"), + N_("specify the reference storage format to use"), PARSE_OPT_HIDDEN), OPT_STRING_LIST('c', "config", &option_config, N_("key=value"), N_("set config inside the new repository")), OPT_STRING_LIST(0, "server-option", &server_options,
Ditto here about either deprecating / using OPT_ALIAS.
quoted hunk ↗ jump to hunk
diff --git a/t/t7424-submodule-mixed-ref-formats.sh b/t/t7424-submodule-mixed-ref-formats.sh index 1ca245c732..5eaf689d74 100755 --- a/t/t7424-submodule-mixed-ref-formats.sh +++ b/t/t7424-submodule-mixed-ref-formats.sh@@ -63,9 +63,9 @@ test_expect_success 'recursive clone propagates ref storage format' ' test_ref_format upstream/submodule "$GIT_DEFAULT_REF_FORMAT" && # The cloned repositories should use the other ref format that we have - # specified via `--ref-format`. The option should propagate to cloned + # specified via `--ref-storage`. The option should propagate to cloned
s/ref-storage/ref-storage-format Rest of the patch looks fine to me. -- Sivaraam