Thread (45 messages) flat view 45 messages, 6 authors, 1d ago

Re: [PATCH v2 1/3] config: add git_config_append_parameter()

From: Thomas Bachem <hidden>
Date: 2026-09-07 16:37:38

Hi Patrick,

On 07/09/2026 10:14, Patrick Steinhardt wrote:
Readers who don't have any context around GIT_CONFIG_PARAMETERS and what
it does will have a bit of a hard time making much sense of this, I
think. It usually helps to give a sentence or two explaining what the
infra even does, and what this quoting looks like.
Will do. It is how "git -c key=value" reaches the child processes: a
space separated list of 'key'='value' pairs, each side single quoted,
that git_config_from_parameters() reads back. I'll say that in the
message.
Pointing to that other function makes sense, but neither of the
functions documents the actual format that's used.
I'll put the format in the header comment as well.

Thanks,
Thomas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help