Re: [PATCH v2 1/3] config: add git_config_append_parameter()

On 07/09/2026 09:14, Patrick Steinhardt wrote:

On Fri, Sep 04, 2026 at 03:51:24PM +0000, Thomas Bachem via GitGitGadget wrote:

quoted

From: Thomas Bachem <redacted>

diff --git a/config.c b/config.c
index d9019e7e6c..e0bb29b53d 100644
--- a/config.c
+++ b/config.c

@@ -450,18 +450,24 @@ static int git_config_include(const char *var, const char *value,
  	return ret;
  }
  
+void git_config_append_parameter(struct strbuf *env, const char *key,

Nit: callling this `env` assumes a bit too much about what this buffer
is going to be used for. I'd have called it just `buf`.

Are we ever likely to use this outside of GIT_CONFIG_PARAMETERS? If not 
then I think env is a good name because it hints at where this function 
is used. Isn't the whole point of this function to allow us to append 
settings an environment variable?

Thanks

Phillip