Re: [PATCH 08/10] builtin/fsck: move bitmap verification into the packed source

On Thu, Aug 27, 2026 at 06:54:51AM -0400, Karthik Nayak wrote:

Patrick Steinhardt [off-list ref] writes:

quoted

The checks for bitmaps live in `verify_bitmap_files()`, which is called
by "builtin/fsck.c". These checks are obviously specific to the "packed"
backend.

Move the logic into `odb_source_packed_fsck()`. As in preceding commits,
this means that we now properly honor both "--connectivity-only" and
"--no-full". Furthermore, we drop the dedicated `ERROR_BITMAP` bit and
instead use the generic `ERROR_OBJECT` bit.

Note that this change also adapts `verify_bitmap_files()` to be
focussed on a single "packed" source instead of verifying bitmaps from

nit: s/focussed/focused

You can actually use both spellings [1], where "focussed" is more
commonly used in the UK. Anyway, I'll change this to help our American
friends out there.

Patrick

[1]: https://en.wiktionary.org/wiki/focussed