Thread (36 messages) flat view 36 messages, 2 authors, 5d ago

Re: [PATCH 08/10] builtin/fsck: move bitmap verification into the packed source

From: Karthik Nayak <hidden>
Date: 2026-08-27 10:54:55

Patrick Steinhardt [off-list ref] writes:
The checks for bitmaps live in `verify_bitmap_files()`, which is called
by "builtin/fsck.c". These checks are obviously specific to the "packed"
backend.

Move the logic into `odb_source_packed_fsck()`. As in preceding commits,
this means that we now properly honor both "--connectivity-only" and
"--no-full". Furthermore, we drop the dedicated `ERROR_BITMAP` bit and
instead use the generic `ERROR_OBJECT` bit.

Note that this change also adapts `verify_bitmap_files()` to be
focussed on a single "packed" source instead of verifying bitmaps from
nit: s/focussed/focused
all sources. This change is required as we already know to loop around
the sources in `odb_fsck()` itself.
[snip]

changes look good

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help