Thread (27 messages) flat view 27 messages, 4 authors, 6d ago

Re: [PATCH v2 4/6] gitk: use more natural language for labels of color preferences

From: Johannes Sixt <hidden>
Date: 2026-08-13 19:35:56

Am 13.08.26 um 19:00 schrieb Mark Levedahl:
On 8/12/26 9:16 AM, Johannes Sixt via GitGitGadget wrote:
quoted
         markbg      markbgcolor {} \
-                    [mc "Marked line bg"] \
+                    [mc "Marked line background"] \
                     [mc "marked line background"] \
Not a new issue, but "marked line" is not a good description. What this actually controls
is the background color of commit message text found by search criteria in the gui, not
lines of text, and (as far as I can tell) never any text found in the patch text.
Actually, it is the background color of lines found via "Show origin of
this line" in the diff panel.

When reading this code for the first time, I thought it has to do with
the "Mark this commit" in the commit list, but it doesn't.

-- Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help