Thread (27 messages) flat view 27 messages, 4 authors, 4d ago

Re: [PATCH 3/5] gitk: show color preferences on the button instead of the label

From: Johannes Sixt <hidden>
Date: 2026-08-08 09:33:22

Am 07.08.26 um 16:37 schrieb mark:
But, the colored buttons do not stand out to my eye as much as in the prior approach.
Perhaps use -borderwidth 2?
I agree. -borderwith 2 does help emphasize that these are clickable
buttons. I'll also insert a small space between the buttons like this:
@@ -11868,9 +11868,9 @@ proc prefspage_colors {notebook} {
 
     foreach {uielem colorvar idx label title} $coloruielems {
         ttk::label $page.$uielem -text $label
-        button $page.${uielem}btn -padx 40 -pady 0 \
+        button $page.${uielem}btn -padx 40 -pady 0 -borderwidth 2 \
             -command [list choosecolor $colorvar $idx $page $title]
-        grid x $page.$uielem $page.${uielem}btn -sticky w
+        grid x $page.$uielem $page.${uielem}btn -sticky w -pady 1
     }
 
     grid columnconfigure $page 2 -weight 1


-- Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help