[PATCH v6 0/4] environment: migrate 'trust_executable_bit' and 'has_symlinks' into 'repo_config_values'
From: Tian Yuchen <hidden>
Date: 2026-07-16 08:49:54
This series moves 'trust_executable_bit' and 'has_symlinks' into 'struct repo_config_values' to tie them to the specific repository instance they were read from. Eager parsing is maintained because these two flags are heavily consulted in hot paths. Note: 'repo_config_values()' still does not support any struct repository other than the_repository due to how deeply these flags are accessed. In other words, this series of patches is laying the groundwork for the eventual elimination of the_repository. Previous related work: [PATCH 2/6] config: add trust_executable_bit to global config [1] [PATCH] Refactor 'trust_executable_bit' to repository-scoped setting [2] (This previous attempt was unsuccessful because the target location selected was 'struct repo_settings', which our analysis indicated was not the optimal choice. For further details, please see: [3]) [PATCH 5/6] config: move has_symlinks [4] RFC: - Is the locations of the newly introduced definitions/macros appropriate? Change since V5: - do not intruduce new global variable to deal with compat/mingw.c. Make use of macro preprocessing to allow platforms to override platform_has_symlinks(). Thanks! [1] https://lore.kernel.org/git/837b5360b40f992351f489a0ae05fedf49884c6e.1685716420.git.gitgitgadget@gmail.com/ (local) [2] https://lore.kernel.org/git/20260301190017.53539-1-dronarajgyawali@gmail.com/ (local) [3] https://lore.kernel.org/git/xmqq1pht6nyx.fsf@gitster.g/ (local) [4] https://lore.kernel.org/git/a154008619790f7a60f2bba91db7b0fe29e67e1a.1685716420.git.gitgitgadget@gmail.com/ (local) [5] https://lore.kernel.org/git/xmqq7bokebct.fsf@gitster.g/ (local) Tian Yuchen (4): read-cache: remove redundant extern declarations read-cache: move 'ce_mode_from_stat()' to 'read-cache.c' environment: move trust_executable_bit into repo_config_values environment: move has_symlinks into repo_config_values apply.c | 4 ++-- combine-diff.c | 2 +- compat/mingw.c | 17 +++++++++++++---- compat/mingw.h | 3 +++ entry.c | 2 +- environment.c | 27 +++++++++++++++++++++++---- environment.h | 8 ++++++-- git-compat-util.h | 4 ++++ read-cache.c | 33 ++++++++++++++++++++++++++------- read-cache.h | 16 ++-------------- 10 files changed, 81 insertions(+), 35 deletions(-) -- 2.43.0