Re: [PATCH v1 3/4] environment: move 'trust_executable_bit' into repo_config_values
From: Christian Couder <hidden>
Date: 2026-05-30 18:02:23
On Sat, May 30, 2026 at 6:05 PM Tian Yuchen [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -720,5 +719,6 @@ void repo_config_values_init(struct repo_config_values *cfg) { cfg->attributes_file = NULL; cfg->apply_sparse_checkout = 0; + cfg->trust_executable_bit = 1;
Here `trust_executable_bit` is processed after `apply_sparse_checkout` ...
quoted hunk ↗ jump to hunk
cfg->branch_track = BRANCH_TRACK_REMOTE; }diff --git a/environment.h b/environment.h index 123a71cdc8..72c400923d 100644 --- a/environment.h +++ b/environment.h@@ -90,6 +90,7 @@ struct repository; struct repo_config_values { /* section "core" config values */ char *attributes_file; + int trust_executable_bit; int apply_sparse_checkout;
... but here it is before `apply_sparse_checkout`. I think it would make more sense to put `trust_executable_bit` after `apply_sparse_checkout` here.
/* section "branch" config values */