[PATCH v3 4/9] sequencer: remove unnecessary "or" in pick_one_commit()
From: Phillip Wood <hidden>
Date: 2026-07-15 15:22:23
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Phillip Wood <redacted> If error_with_patch(..., res, ...) succeeds then it returns "res", if it fails then it returns -1. This means that or-ing the return value with "res" is pointless as the result is the same as the return value. Signed-off-by: Phillip Wood <redacted> --- sequencer.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/sequencer.c b/sequencer.c
index 1db844100ad..70e12eab0ec 100644
--- a/sequencer.c
+++ b/sequencer.c@@ -5007,9 +5007,8 @@ static int pick_one_commit(struct repository *r, oideq(&opts->squash_onto, &oid)))) to_amend = 1; - return res | error_with_patch(r, item->commit, - arg, item->arg_len, opts, - res, to_amend); + return error_with_patch(r, item->commit, arg, item->arg_len, + opts, res, to_amend); } return res; }
--
2.54.0.200.gfd8d68259e3