Re: [PATCH v2 01/12] load_one_loose_object_map(): fix resource leak
From: Patrick Steinhardt <hidden>
Date: 2026-07-07 15:56:01
On Sun, Jul 05, 2026 at 08:24:18AM +0000, Johannes Schindelin via GitGitGadget wrote:
quoted hunk ↗ jump to hunk
@@ -98,13 +98,12 @@ static int load_one_loose_object_map(struct repository *repo, struct odb_source_ insert_loose_map(loose, &oid, &compat_oid); } - strbuf_release(&buf); - strbuf_release(&path); - return errno ? -1 : 0; + ret = ferror(fp) ? -1 : 0; err: + fclose(fp); strbuf_release(&buf); strbuf_release(&path); - return -1; + return ret;
Nit: it might've made sense to explain the switch to ferror(3p) in the commit message, but that alone isn't worth a reroll. Patrick