Thread (42 messages) 42 messages, 4 authors, 7h ago
HOTtoday

[PATCH v2 11/13] setup: drop redundant configuration of `startup_info->have_repository`

From: Patrick Steinhardt <hidden>
Date: 2026-07-07 07:22:01
Subsystem: the rest · Maintainer: Linus Torvalds

In `init_db()` we set `startup_info->have_repository` twice: once before
reading and applying the repository format and once after. This is
redundant though, as configuring the repository format does not rely on
this variable at all.

Remove the first such site. While at it, fix up formatting a bit.

Signed-off-by: Patrick Steinhardt <redacted>
---
 setup.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/setup.c b/setup.c
index d4de8c2900..088e7b85f7 100644
--- a/setup.c
+++ b/setup.c
@@ -2847,12 +2847,10 @@ int init_db(struct repository *repo,
 		apply_and_export_relative_gitdir(repo, real_git_dir, 1);
 		git_dir = repo_get_git_dir(repo);
 		separate_git_dir(git_dir, original_git_dir);
-	}
-	else {
+	} else {
 		apply_and_export_relative_gitdir(repo, git_dir, 1);
 		git_dir = repo_get_git_dir(repo);
 	}
-	startup_info->have_repository = 1;
 
 	/*
 	 * Check to see if the repository version is right.
-- 
2.55.0.141.g00534a21ce.dirty
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help