Thread (2 messages) 2 messages, 2 authors, 2d ago
WARM2d

[PATCH v2] setup.c: use die_errno() when chdir() system call fails

From: Gatla Vishweshwar Reddy <hidden>
Date: 2026-07-06 19:14:29
Subsystem: the rest · Maintainer: Linus Torvalds

When chdir() fails, the errno value contains the reason for the
failure. Using die() instead of die_errno() loses this information,
making it harder to diagnose failures. Switch to die_errno() to
include the system error message in the output.

Signed-off-by: Gatla Vishweshwar Reddy <redacted>
---
 setup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/setup.c b/setup.c
index b4652651df..e2e98d1126 100644
--- a/setup.c
+++ b/setup.c
@@ -1954,13 +1954,13 @@ const char *setup_git_directory_gently(struct repository *repo, int *nongit_ok)
 		break;
 	case GIT_DIR_DISCOVERED:
 		if (dir.len < cwd.len && chdir(dir.buf))
-			die(_("cannot change to '%s'"), dir.buf);
+			die_errno(_("cannot change to '%s'"), dir.buf);
 		prefix = setup_discovered_git_dir(repo, gitdir.buf, &cwd, dir.len,
 						  &repo_fmt, nongit_ok);
 		break;
 	case GIT_DIR_BARE:
 		if (dir.len < cwd.len && chdir(dir.buf))
-			die(_("cannot change to '%s'"), dir.buf);
+			die_errno(_("cannot change to '%s'"), dir.buf);
 		prefix = setup_bare_git_dir(repo, &cwd, dir.len, &repo_fmt, nongit_ok);
 		break;
 	case GIT_DIR_HIT_CEILING:
-- 
2.54.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help