Thread (43 messages) 43 messages, 7 authors, 7d ago

Re: [PATCH v4 0/2] Makefile: link osxkeychain helper against Rust

From: Shardul Natu <hidden>
Date: 2026-07-05 17:39:07

This was addressing Patrick's comment, which was already done in v3;
hopefully that is now settled?
Sorry, updated the description of the PR!
It is a mystery what the third bullet point was ;-)
Remnant of thoughts! Removed!!

Thank you,
  Shardul

On Sat, Jul 4, 2026 at 9:08 PM Junio C Hamano [off-list ref] wrote:
"Shardul Natu via GitGitGadget" [off-list ref] writes:
quoted
Changes since v2:

 * Split the original combined commit into a two-patch series to separate
   prerequisite bug fixes from Universal Binary features.
This was addressing Patrick's comment, which was already done in v3;
hopefully that is now settled?
quoted
 * Added $(call mkdir_p_parent_template) prior to invoking lipo to guarantee
   that parent target directories exist.
Obviously correct ;-).
quoted
 *
It is a mystery what the third bullet point was ;-)

The changes relative to v3 (which I looked at) look good now.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help