Thread (43 messages) 43 messages, 7 authors, 15d ago

Re: [PATCH v4 0/2] Makefile: link osxkeychain helper against Rust

From: Junio C Hamano <hidden>
Date: 2026-07-05 04:08:04

"Shardul Natu via GitGitGadget" [off-list ref] writes:
Changes since v2:

 * Split the original combined commit into a two-patch series to separate
   prerequisite bug fixes from Universal Binary features.
This was addressing Patrick's comment, which was already done in v3;
hopefully that is now settled?
 * Added $(call mkdir_p_parent_template) prior to invoking lipo to guarantee
   that parent target directories exist.
Obviously correct ;-).
 * 
It is a mystery what the third bullet point was ;-)

The changes relative to v3 (which I looked at) look good now.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help