Re: [PATCH v4 8/8] doc: promisor: improve acceptFromServer entry
From: Kristoffer Haugsbakk <hidden>
Date: 2026-07-04 09:49:50
On Wed, May 27, 2026, at 16:08, Christian Couder wrote:
The entry for the `promisor.acceptFromServer` in "Documentation/config/promisor.adoc" has a number of issues:
(This series is now in `next` so this is not a review comment)
quoted hunk ↗ jump to hunk
[snip] Documentation/config/promisor.adoc | 53 ++++++++++++++++++++---------- 1 file changed, 35 insertions(+), 18 deletions(-)diff --git a/Documentation/config/promisor.adocb/Documentation/config/promisor.adoc index 455ce40be8..f07a2e883b 100644--- a/Documentation/config/promisor.adoc +++ b/Documentation/config/promisor.adoc@@ -32,24 +32,41 @@ variable is set to "true", and the "name" and "url"fields are always advertised regardless of this setting. [snip] ++ +The available options are: ++ +* `none` (default): No promisor remote advertised by a server will be + accepted.
Why did you use an unordered/bullet list instead of a description list?
++ +* `knownUrl`: The client will accept promisor remotes that are already + configured on the client and have both the same name and the same URL + as advertised by the server. This is more secure than `all` or + `knownName`, and should be used if possible instead of those options. ++ +* `knownName`: The client will accept promisor remotes that are already + configured on the client and have the same name as those advertised + by the server. This is not very secure, but could be used in a corporate + setup where servers and clients are trusted to not switch names and URLs. ++ +* `all`: The client will accept all the promisor remotes a server might + advertise. This is the least secure option and should only be used in + fully trusted environments. ++ +Name and URL comparisons are case-sensitive. See linkgit:gitprotocol-v2[5] +for protocol details. promisor.acceptFromServerUrl:: A glob pattern to specify which server-advertised URLs a -- 2.54.0.275.g96c817d129.dirty