Re: [PATCH GSoC v14 07/13] connect: refactor packet writing
From: Karthik Nayak <hidden>
Date: 2026-06-26 17:03:52
Attachments
- signature.asc [application/pgp-signature] 690 bytes
From: Karthik Nayak <hidden>
Date: 2026-06-26 17:03:52
Pablo Sabater [off-list ref] writes:
The subject is bit too generic no? Maybe we can talk about the function?
Perhaps:
connect: make `write_fetch_command_and_capabilities()` more generic
Refactor `write_fetch_command_and_capabilities()`, enabling it to serve both fetch and additional commands. In this context, "command" refers to the "operations" supported by Git's wire protocol https://git-scm.com/docs/protocol-v2, such as a Git subcommand (e.g., git-fetch(1)) or a server-side operation like "object-info" as implemented in commit a2ba162 (object-info: support for retrieving object info, 2021-04-20). Refactor the function signature to accept a command instead of the hardcoded "fetch".
[snip]