On 26/06/17 08:39AM, Patrick Steinhardt wrote:

 5:  8eb3cb17a1 !  5:  c9b1e1da26 odb/source-packed: start converting to a proper `struct odb_source`
    @@ Commit message
         odb_source`, as it's missing all of the callback implementations. These
         will be wired up in subsequent commits.
     
    +    Further note that we're also registering a `chdir_notify` callback to
    +    reparent our path. This wasn't previously necessary (and still isn't at
    +    this point in time) because all paths are taken from the owning "files"
    +    source, and that source already handles the reparenting for us. But a
    +    subsequent commit will change that so that we're using the path of the
    +    "packed" source, and once that happens we'll need it to be updated when
    +    changing the working directory.

Ah ok, the "file" ODB source already has a `chdir_notify` callback
registered to handle this which is why we could get away with using the
path taken from the parent. Make sense. The explaination here is very
helpful.

This version of the series looks good to me.

Thanks
-Justin