Re: [PATCH v2 11/17] odb/source-packed: wire up `for_each_object()` callback
From: Patrick Steinhardt <hidden>
Date: 2026-06-17 07:26:46
From: Patrick Steinhardt <hidden>
Date: 2026-06-17 07:26:46
On Tue, Jun 16, 2026 at 05:10:28PM -0500, Justin Tobler wrote:
On 26/06/09 10:51AM, Patrick Steinhardt wrote:quoted
diff --git a/packfile.c b/packfile.c index 42c84397eb..b8d6054c16 100644 --- a/packfile.c +++ b/packfile.c@@ -1362,8 +1362,8 @@ static void add_delta_base_cache(struct packed_git *p, off_t base_offset, hashmap_add(&delta_base_cache, &ent->ent); } -static int packed_object_info_with_index_pos(struct packed_git *p, off_t obj_offset, - uint32_t *maybe_index_pos, struct object_info *oi) +int packed_object_info_with_index_pos(struct packed_git *p, off_t obj_offset, + uint32_t *maybe_index_pos, struct object_info *oi)Looks like we are also exposing `packed_object_info_with_index_pos()` now. Not sure yet if this is also intended to be temporary like `find_pack_entry()` in a previous patch though though.
No, it's not. This function is also required in case you just have a single packfile to look up objects in there. So there are use cases outside of the "packed" source where we need it going forward. Patrick