Thread (17 messages) 17 messages, 3 authors, 2d ago

Re: [PATCH v4 0/3] compat/posix.h: enable UNUSED warning messages for Clang

From: Patrick Steinhardt <hidden>
Date: 2026-06-15 08:48:42

On Sat, Jun 13, 2026 at 09:39:03AM -0700, Junio C Hamano wrote:
Dominik Loidolt [off-list ref] writes:
quoted
This series enables the intended UNUSED warning message with Clang by
adding a dedicated Clang version check. It also cleans up the nearby
GIT_GNUC_PREREQ() and UNUSED macros.

Changes since v3:
- split style-only cleanups into their own patch
- fix the UNUSED preprocessor indentation style
- simplify the GIT_GNUC_PREREQ() comparison commit message
- keep the Clang-specific note in the patch that adds GIT_CLANG_PREREQ()

Thanks,
 Dominik

Dominik Loidolt (3):
  compat/posix.h: enable UNUSED warning messages for Clang
  compat/posix.h: clean up GIT_GNUC_PREREQ() and UNUSED
  compat/posix.h: simplify GIT_GNUC_PREREQ() comparison
Looking good and all the points Patrick raised during the review of
the previous round seem to have been addressed nicely.

Will replace.  Shall we mark it for 'next' now?
Yeah, I'm happy with this version. Thanks!

Patrick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help