Thread (2 messages) 2 messages, 2 authors, 2025-11-19

Re: [PATCH] doc: warn against --committer-date-is-author-date

From: Kristoffer Haugsbakk <hidden>
Date: 2025-11-19 16:27:45

On Thu, Oct 16, 2025, at 18:23, Junio C Hamano wrote:
Johannes Sixt [off-list ref] writes:
quoted
[snip]
I do not like the latter. If you do not like the former, I wouldn't mind
not adding the sentence. The warning should be sufficient.
But stepping back a bit, if we truly want to discourage the use of
it, perhaps we should officially deprecate and schedule it for
removal?  If we are *not* brave enough to back such a move, then
perhaps we ourselves are not yet convinced that this should be
discouraged?

My preference is to stop at describing, in WARNING or NOTES, what
the use case that triggered the addition of this option was and
declaring that the use case does not make any sense (your "who would
apply the same series twice on the same base?  just keep the result
on a branch and reuse" would be fine), but without saying "Do not
use this option".  In other words, the message is "We'd give a long
rope that we do not think is very useful, but it is up to you to get
yourself tangled in it".
I agree with just warning.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help