Le 6 nov. 2025 à 02:22, Patrick Steinhardt [off-list ref] a écrit :

On Tue, Nov 04, 2025 at 01:14:57PM -0500, D. Ben Knoble wrote:

quoted

When install git-contacts with Meson via -Dcontrib=contacts, the default

s/install/installing/

Thanks. If Junio doesn’t mind the trivial fix, I’ll avoid sending v2 for now :)

quoted

Perl generation fails to mark it executable. As a result, "git contacts"
reports "'contacts' is not a git command."

Unlike generate-script.sh, we aren't testing the basename here; so, glob
the script name in the case arm to match wherever the input comes from.

Yeah, that feels sensibel to me.

quoted

diff --git a/generate-perl.sh b/generate-perl.sh
index 65f122ebfc..796d835932 100755
--- a/generate-perl.sh
+++ b/generate-perl.sh

@@ -30,7 +30,7 @@
    "$INPUT" >"$OUTPUT"

case "$INPUT" in
-*.perl)
+*.perl|*git-contacts)
   chmod a+x "$OUTPUT";;
*)
   ;;

And the change looks as expected. An alternative could of course be to
rename the file in-tree to "git-contacts.perl". In that case we wouldn't
require this special case at all. But I guess that this here is good
enough, and there might be other consequences if we renamed the script.

My worry too. 

Thanks!

Patrick

Thanks for the review!