[PATCH] perl: also mark git-contacts executable
From: D. Ben Knoble <hidden>
Date: 2025-11-04 18:21:07
Subsystem:
the rest · Maintainer:
Linus Torvalds
When install git-contacts with Meson via -Dcontrib=contacts, the default Perl generation fails to mark it executable. As a result, "git contacts" reports "'contacts' is not a git command." Unlike generate-script.sh, we aren't testing the basename here; so, glob the script name in the case arm to match wherever the input comes from. Signed-off-by: D. Ben Knoble <redacted> --- Tested like [1]. I was surprised to find my packager didn't have contacts installed, despite it being requested. But the issue is upstream (here): the installer doesn't mark the program as executable. I wrote this on top of the patch in [1], but it should be independent. A quick test says the prerequisite-patch-id shouldn't bother application? [1]: https://lore.kernel.org/git/0423F0C4-D0AD-471D-9315-FB208A8171B4@gmail.com/T/#t (local) generate-perl.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/generate-perl.sh b/generate-perl.sh
index 65f122ebfc..796d835932 100755
--- a/generate-perl.sh
+++ b/generate-perl.sh@@ -30,7 +30,7 @@ "$INPUT" >"$OUTPUT" case "$INPUT" in -*.perl) +*.perl|*git-contacts) chmod a+x "$OUTPUT";; *) ;;
base-commit: 7f278e958afbf9b7e0727631b4c26dcfa1c63d6e prerequisite-patch-id: 664e4667d11a226a89da52814505a0c8d31b9fba -- 2.48.1