On Mon, Oct 27, 2025 at 10:56 AM Junio C Hamano [off-list ref] wrote:

Eric Sunshine [off-list ref] writes:

quoted

Or, even better, scope the strbuf just to the `case` branch which needs it:

    case FORMAT_KEYVALUE: {
        struct strbuf buf = STRBUF_INIT;
        quote_c_style(value, buf, NULL, 0);
        printf("%s=%s\n", key, buf->buf);
        strbuf_release(&buf);
        break;
     }

For something simple like this, quote_c_style() can take "FILE *"
instead of struct "strbuf *" so that you do not have to allocate;
especially without any need for i18n, perhaps

    printf("%s=", key);
    quote_c_style(value, NULL, stdout, 0);

Thanks, that's even better. Nice and clean and easy to read.

(I didn't have the Git source code at hand, so didn't know that
`quote_c_style` could take `FILE *`.)