Thread (2 messages) 2 messages, 2 authors, 2025-10-27

Re: [PATCH v3 1/2] repo: factor out field printing to dedicated function

From: Junio C Hamano <hidden>
Date: 2025-10-27 14:56:38

Eric Sunshine [off-list ref] writes:
Or, even better, scope the strbuf just to the `case` branch which needs it:

    case FORMAT_KEYVALUE: {
        struct strbuf buf = STRBUF_INIT;
        quote_c_style(value, buf, NULL, 0);
        printf("%s=%s\n", key, buf->buf);
        strbuf_release(&buf);
        break;
     }
Yuck.  

For something simple like this, quote_c_style() can take "FILE *"
instead of struct "strbuf *" so that you do not have to allocate;
especially without any need for i18n, perhaps

    printf("%s=", key);
    quote_c_style(value, NULL, stdout, 0);

is sufficient?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help