Re: [PATCH 3/6] revision: add wrapper to setup_revisions() from a strvec
From: Eric Sunshine <hidden>
Date: 2025-09-20 05:11:02
From: Eric Sunshine <hidden>
Date: 2025-09-20 05:11:02
On Fri, Sep 19, 2025 at 6:51 PM Jeff King [off-list ref] wrote:
The setup_revisions() function was designed to take the argc/argv pair from the operating system. But we sometimes construct our own argv using a strvec and pass that in. There are a few gotchas that callers need to deal with here: [...] We'll start by converting all of the call-sites which the free_removed_argv_elements option. There should be no behavior change for them, except that their "shrunken" entries are cleaned up immediately, rather than waiting for a strvec_clear() call.
There is some grammatical problem with the first sentence of this paragraph which makes it difficult to decipher.
Signed-off-by: Jeff King <redacted>