Re: [PATCH 5/6] treewide: pass strvecs around for setup_revisions_from_strvec()
From: Jeff King <hidden>
Date: 2025-09-19 23:11:28
Subsystem:
the rest · Maintainer:
Linus Torvalds
On Fri, Sep 19, 2025 at 06:50:48PM -0400, Jeff King wrote:
quoted hunk ↗ jump to hunk
diff --git a/shallow.h b/shallow.h index 9bfeade93e..59d54d48e7 100644 --- a/shallow.h +++ b/shallow.h@@ -36,8 +36,8 @@ void rollback_shallow_file(struct repository *r, struct shallow_lock *lk); struct commit_list *get_shallow_commits(struct object_array *heads, int depth, int shallow_flag, int not_shallow_flag); -struct commit_list *get_shallow_commits_by_rev_list( - int ac, const char **av, int shallow_flag, int not_shallow_flag); +struct commit_list *get_shallow_commits_by_rev_list(struct strvec *argv, + int shallow_flag, int not_shallow_flag); int write_shallow_commits(struct strbuf *out, int use_pack_protocol, const struct oid_array *extra);
Sorry, I missed a hdr-check complaint here. It needs:
diff --git a/shallow.h b/shallow.h
index 59d54d48e7..ad591bd139 100644
--- a/shallow.h
+++ b/shallow.h@@ -7,6 +7,7 @@ #include "strbuf.h" struct oid_array; +struct strvec; void set_alternate_shallow_file(struct repository *r, const char *path, int override); int register_shallow(struct repository *r, const struct object_id *oid);
on top. -Peff