Thread (29 messages) flat view 29 messages, 7 authors, 2025-07-22

Re: [PATCH v3 0/3] C99: declare bool experiment a success

From: Karthik Nayak <hidden>
Date: 2025-07-22 08:09:32

Phillip Wood [off-list ref] writes:
Hi Karthik

On 16/07/2025 11:29, Karthik Nayak wrote:
quoted
Phillip Wood [off-list ref] writes:
quoted
From: Phillip Wood <redacted>

We've had a test balloon for C99's bool type since 8277dbe987
(git-compat-util: convert skip_{prefix,suffix}{,_mem} to bool,
2023-12-16). As it has been over 18 months since this was added and
there have been no complaints let's declare it a success and convert
the return type our other string predicates to match.
Neat, I didn't even know we were running such an experiment. Thanks for
getting around to it, I think the patches look great, added some
complaints from 'clang-format', feel free to ignore.
Thanks for taking a look. I would have fixed the formatting but this is
in next already so I'll leave it as it is if that's ok with you.
Of course :) These are small nits. I'm mostly interested in getting
clang-format to work without any/many false positives, so I'm trying to
test it with different patches that I read and report back!
Thanks

Phillip

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help