Thread (29 messages) read the whole thread 29 messages, 7 authors, 2025-07-22
STALE374d

Revision v3 of 3 in this series.

Revisions (3)
  1. v1 [diff vs current]
  2. v2 [diff vs current]
  3. v3 current

[PATCH v3 0/3] C99: declare bool experiment a success

From: Phillip Wood <hidden>
Date: 2025-07-16 09:39:22

From: Phillip Wood <redacted>

We've had a test balloon for C99's bool type since 8277dbe987
(git-compat-util: convert skip_{prefix,suffix}{,_mem} to bool,
2023-12-16). As it has been over 18 months since this was added and
there have been no complaints let's declare it a success and convert
the return type our other string predicates to match.

Thanks to peff for spotting yet another typo - I've updated the commit
message for patch 1 accordingly.

Base-Commit: a30f80fde927d70950b3b4d1820813480968fb0d
Published-As: https://github.com/phillipwood/git/releases/tag/pw%2Fuse-c99-bool%2Fv3
View-Changes-At: https://github.com/phillipwood/git/compare/a30f80fde...80e5cd3b9
Fetch-It-Via: git fetch https://github.com/phillipwood/git pw/use-c99-bool/v3


Phillip Wood (3):
  CodingGuidelines: allow the use of bool
  git-compat-util: convert string predicates to return bool
  strbuf: convert predicates to return bool

 Documentation/CodingGuidelines |  3 +++
 git-compat-util.h              | 12 ++++++------
 strbuf.c                       | 28 ++++++++++++++--------------
 strbuf.h                       | 12 ++++++------
 4 files changed, 29 insertions(+), 26 deletions(-)

Range-diff against v2:
1:  352f80c49b7 ! 1:  3ff7ae61f45 CodingGuildlines: allow the use of bool
    @@ Metadata
     Author: Phillip Wood [off-list ref]
     
      ## Commit message ##
    -    CodingGuildlines: allow the use of bool
    +    CodingGuidelines: allow the use of bool
     
         We have had a test balloon for C99's bool type since 8277dbe987
         (git-compat-util: convert skip_{prefix,suffix}{,_mem} to bool,
2:  0b2402e11cc = 2:  26c3f48ac6c git-compat-util: convert string predicates to return bool
3:  66968714739 = 3:  80e5cd3b9df strbuf: convert predicates to return bool
-- 
2.49.0.897.gfad3eb7d210
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help