On Thu, Jun 05, 2025 at 11:53:32AM -0400, Derrick Stolee wrote:

On 6/3/2025 10:01 AM, Patrick Steinhardt wrote:

quoted

Hi,

this patch series fixes races around locking the "packed-refs" file when
auto-maintenance decides to repack it. This issue has been reported e.g.
via [1] and [2].

The root cause is that git-gc(1) used to know to detach _after_ having
repacked references. As such, callers wouldn't continue with their thing
until we have already packed refs, and thus the race does not exist
there. git-maintenance(1) didn't have the same split though, so this
patch series retrofits that logic.

Thanks for making these changes. I read this v4 and only found an
opportunity to improve our docs relative to the more helpful errors
around using --schedule and --task together. I sent a diff that could
be squashed in or skipped.

I see that the series got merged yesterday, so your mail overlapped with
that. I think it's a good addition though, so would you mind sending the
diff as a follow-up patch?

Thanks for your review!

Patrick