Thread (31 messages) 31 messages, 3 authors, 2025-03-13

Re: [PATCH v3 0/1] pack-objects: freshen objects with multi-cruft packs

From: Patrick Steinhardt <hidden>
Date: 2025-03-06 10:31:46

On Tue, Mar 04, 2025 at 07:15:14PM -0500, Taylor Blau wrote:
This is a(nother) reroll of my series to fix a bug in freshening objects
with multiple cruft packs.

The only update since last time is that I dropped the first patch, after
Patrick astutely pointed out a flaw with the approach pursued there.
That flaw is why I wrote '--max-cruft-size' in what appeared to be a
convoluted fashion, but I couldn't remember my line of thinking at the
time.

As usual, there is a range-diff showing as much below. Thanks again,
Patrick, for catching what would be a very frustrating issue to deal
with later on ;-).
Would it maybe make sense to add a commit that explains _why_ the
existing algorithm looks as it does so that the next person won't be
triggered to remove the code again?

Patrick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help