On Tue, Mar 04, 2025 at 02:55:00PM -0800, Elijah Newren wrote:

v2 looks good to me; though I'm curious if some wording improvement in
the commit message might help in distinguishing between
--max-cruft-size and --max-pack-size...and whether we want to provide
any checks on the relative sizes of the two.

Thanks for the review! :-)

--max-cruft-size and --max-pack-size are the same thing from
pack-objects' perspective; the two flags exist at the repack level in
case you want to set a different maximum pack size for cruft- and
non-cruft packs.

Both end up as a --max-pack-size value when repack invokes pack-objects
for the cruft and non-cruft case.

Thanks,
Taylor