Thread (24 messages) flat view 24 messages, 3 authors, 2025-02-06

Re: [PATCH v3 1/5] refactor(remote): rename function omit_name_by_refspec

From: Patrick Steinhardt <hidden>
Date: 2025-02-03 06:46:02

On Sat, Feb 01, 2025 at 12:11:58PM +0530, Meet Soni wrote:

Please drop the `refactor()` bit from the commit subject, we don't use
these prefixes here. You also did the same in a later commit.
Rename the function `omit_name_by_refspec()` to
`refname_matches_negative_refspec_item()` to provide clearer intent.
The previous function name was vague and did not accurately describe its
purpose. By using `refname_matches_negative_refspec_item`, make the
function's purpose more intuitive, clarifying that it checks if a
reference name matches any negative refspec.
The new name certainly reads way better, and the changes themselves look

Patrick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help