Re: [PATCH v2 3/5] backfill: add --min-batch-size=<n> option
From: Patrick Steinhardt <hidden>
Date: 2025-01-16 10:01:08
On Fri, Dec 20, 2024 at 04:29:51PM +0000, Derrick Stolee via GitGitGadget wrote:
From: Derrick Stolee <redacted> Users may want to specify a minimum batch size for their needs. This is only a minimum: the path-walk API provides a list of OIDs that correspond to the same path, and thus it is optimal to allow delta compression across those objects in a single server request. We could consider limiting the request to have a maximum batch size in the future. For now, we let the path-walk API batches determine the boundaries. To get a feeling for the value of specifying the --batch-size parameter,
This should say `--min-batch-size`.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/git-backfill.txt b/Documentation/git-backfill.txt index ece887831f6..e392517869c 100644 --- a/Documentation/git-backfill.txt +++ b/Documentation/git-backfill.txt@@ -9,7 +9,7 @@ git-backfill - Download missing objects in a partial clone SYNOPSIS -------- [verse] -'git backfill' [<options>] +'git backfill' [--batch-size=<n>] DESCRIPTION -----------
Here, as well.
quoted hunk ↗ jump to hunk
diff --git a/builtin/backfill.c b/builtin/backfill.c index 177fd4286c7..ddccececc36 100644 --- a/builtin/backfill.c +++ b/builtin/backfill.c@@ -21,14 +21,14 @@ #include "path-walk.h" static const char * const builtin_backfill_usage[] = { - N_("git backfill [<options>]"), + N_("git backfill [--batch-size=<n>]"),
And here.
quoted hunk ↗ jump to hunk
@@ -111,9 +111,11 @@ int cmd_backfill(int argc, const char **argv, const char *prefix, struct reposit struct backfill_context ctx = { .repo = repo, .current_batch = OID_ARRAY_INIT, - .batch_size = 50000, + .min_batch_size = 50000, };
Nit: it would be nice to adjust the name of this variable in the preceding commit already so that it doesn't have to change again over here. Patrick