Re: [PATCH v2 4/4] worktree: prevent null pointer dereference
From: Caleb White <hidden>
Date: 2024-10-07 03:09:47
Attachments
- signature.asc [application/pgp-signature] 509 bytes
From: Caleb White <hidden>
Date: 2024-10-07 03:09:47
On Sunday, October 6th, 2024 at 18:24, Eric Sunshine [off-list ref] wrote:
Reviewers are a limited resource on this project[1], so it's ideal if submissions can be as reviewer-friendly as possible. Extraneous patches, unnecessary or unrelated changes to surrounding code, etc. all make a patch series more onerous to review, thus are best avoided. (This concern prompted all the review comments I left on this patch.) So, let's drop this patch since it adds no value to either this series or to the existing codebase. If someone needs such a change later on, they can resurrect the change.
Sounds good, dropped.
[1] There are far more people submitting patches to the project than reviewing them. For instance, according to Junio's latest "What's Cooking" report[2], the patch I submitted[3] a couple weeks ago to fix "git worktree repair" to handle manual copy operations is still awaiting review. (Since you've now been living in the worktree code a bit and have had to digest the "repair" logic, perhaps you'd be interested in reviewing that patch?)
I'd be happy to take a look!