Thread (38 messages) 38 messages, 4 authors, 2024-10-07
STALE634d
Revisions (2)
  1. v1 [diff vs current]
  2. v2 current

[PATCH v2 4/4] worktree: prevent null pointer dereference

From: Caleb White <hidden>
Date: 2024-10-06 06:01:40
Subsystem: the rest · Maintainer: Linus Torvalds

If worktrees is NULL, free_worktrees() should return immediately to
prevent a null pointer dereference.

Signed-off-by: Caleb White <redacted>
---
 worktree.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/worktree.c b/worktree.c
index b08ecce..1cf15b0 100644
--- a/worktree.c
+++ b/worktree.c
@@ -28,8 +28,9 @@ void free_worktree(struct worktree *worktree)
 
 void free_worktrees(struct worktree **worktrees)
 {
-	int i = 0;
-	for (i = 0; worktrees[i]; i++)
+	if  (!worktrees)
+		return;
+	for (int i = 0; worktrees[i]; i++)
 		free_worktree(worktrees[i]);
 	free (worktrees);
 }
-- 
2.46.2

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help