Re: [PATCH v3 4/6] config: add git_configset_alloc() and git_configset_clear_and_free()
From: Eric Sunshine <hidden>
Date: 2024-09-06 23:24:34
On Fri, Sep 6, 2024 at 6:21 PM Calvin Wan [off-list ref] wrote:
From: Josh Steadmon <redacted> Add git_configset_alloc() and git_configset_clear_and_free() functions so that callers can manage config_set structs on the heap. This also allows non-C external consumers to treat config_sets as opaque structs. Co-authored-by: Calvin Wan [off-list ref] Signed-off-by: Calvin Wan <redacted>
Almost all these patches suffer from some sort of missing Josh trailer, so I'll stop mentioning it now.
quoted hunk ↗ jump to hunk
diff --git a/config.h b/config.h@@ -472,6 +472,11 @@ struct config_set { +/** + * Alloc a config_set + */ +struct config_set *git_configset_alloc(void);
Should this documentation string mention that git_configset_alloc() does _not_ initialize the configset? Alternatively, should this function also initialize it as a convenience (and mention so in the documentation)?