Re: [PATCH 09/11] t-reftable-record: add index tests for reftable_record_is_deletion()
From: Karthik Nayak <hidden>
Date: 2024-06-25 09:19:49
Chandra Pratap [off-list ref] writes:
reftable_record_is_deletion() is a function defined in
reftable/record.{c, h} that determines whether a record is of
type deletion or not. In the current testing setup, this functionNit: 'In the current testing setup' holds true for the series, but on a commit level, this statement needs to be modified with each tackled type.
quoted hunk ↗ jump to hunk
is left untested for all the four record types (ref, log, obj, index). Add tests for this function in the case of index records. Note that since index records cannot be of type deletion, this function must always return '0' when called on an index record. Mentored-by: Patrick Steinhardt [off-list ref] Mentored-by: Christian Couder [off-list ref] Signed-off-by: Chandra Pratap <redacted> --- t/unit-tests/t-reftable-record.c | 1 + 1 file changed, 1 insertion(+)diff --git a/t/unit-tests/t-reftable-record.c b/t/unit-tests/t-reftable-record.c index 766431ca67..99ebfafe0b 100644 --- a/t/unit-tests/t-reftable-record.c +++ b/t/unit-tests/t-reftable-record.c@@ -477,6 +477,7 @@ static void test_reftable_index_record_roundtrip(void) reftable_record_key(&in, &key); test_copy(&in); + check(!reftable_record_is_deletion(&in)); check(!strbuf_cmp(&key, &in.u.idx.last_key)); n = reftable_record_encode(&in, dest, GIT_SHA1_RAWSZ); check_int(n, >, 0); --2.45.2.404.g9eaef5822c
Attachments
- signature.asc [application/pgp-signature] 690 bytes