Thread (73 messages) 73 messages, 4 authors, 2024-07-02
STALE725d

[PATCH 09/11] t-reftable-record: add reftable_record_is_deletion() test for index records

From: Chandra Pratap <hidden>
Date: 2024-06-21 06:02:07
Subsystem: the rest · Maintainer: Linus Torvalds

reftable_record_is_deletion() is a function defined in
reftable/record.{c, h} which determines whether a record is of
type deletion or not. Since index records can never be of type deletion,
this function must always return 0 when called on an index record.
In the current testing setup for index records, this functionality is
left untested. Add a test for the same.

Mentored-by: Patrick Steinhardt [off-list ref]
Mentored-by: Christian Couder [off-list ref]
Signed-off-by: Chandra Pratap <redacted>
---
 t/unit-tests/t-reftable-record.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/t/unit-tests/t-reftable-record.c b/t/unit-tests/t-reftable-record.c
index 204a673260..bb2986eef6 100644
--- a/t/unit-tests/t-reftable-record.c
+++ b/t/unit-tests/t-reftable-record.c
@@ -471,6 +471,7 @@ static void test_reftable_index_record_roundtrip(void)
 	reftable_record_key(&in, &key);
 	test_copy(&in);
 
+	check(!reftable_record_is_deletion(&in));
 	check(!strbuf_cmp(&key, &in.u.idx.last_key));
 	n = reftable_record_encode(&in, dest, GIT_SHA1_RAWSZ);
 	check_int(n, >, 0);
-- 
2.45.2.404.g9eaef5822c
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help